I have bee learning PHP for some time now, and covered a little ground in it. But all that has been in procedual style. So I decided to delve into OOP it being the most secure of both and more organized. Here is my problem:
<?php
class connect{
public $db_host= "localhost";
public $username="";
public $password= "";
public $db_name="";
public $dbc;
function db_connect(){
try{
$this->dbc= new PDO("mysql:host=$this->db_host; dbname=$this->db_name", $this->username, $this->password);
mysql_select_db($this->db_name);
}
catch (PDOException $e){
echo "failed to connect to database pdo ";
echo $e->getmessage();
exit();
}
return $this->dbc;
}
public $sql, $row, $result;
public function tester(){
if(mysql_connect())
{
$this->result=mysql_query("SELECT email FROM users WHERE id =1";
$this->row=mysql_fetch_row($this->result);
$this->sql=$this->row['email'];
}
else{
$this->sql= "bah quannection";
}
return $this->sql;
}
}
$connection = new connect();
$connection->db_connect();
echo "you are an OOP genius";
$connection->tester();
echo $connection->sql;
?>
and it keeps outputting " you are an OOP genius
Warning: mysql_fetch_row() expects parameter 1 to be resource, boolean given in C:\xampp\htdocs\Experiments\gstosa\index.php on line 29

Warning? Why don't you ask it if it is a genius, too?

I am not a mysql programmer, but I suggest that your SELECT statement is failing.

This could be because the correct schema containing your table has not been specified, the connected user does not have authority to the table, the table name or a field has been misspelled, or id is alphanumeric.

You may want to call something like mysqli_error() or mysql_error() ?? to display what the error is.

you are mixing mysql and pdo functions, it doesn't work that way

Jregz:
you are mixing mysql and pdo functions, it doesn't work that way

When will folk stop saying "it doesn't work that way"!!

More explanation please.

It seems to me that the connection is successful, because the program gets to the point row=mysql_fetch_row, and it is complaining that the wrong parameter has been passed. This would appear to be because the SELECT has failed and is returning FALSE instead of a result set.

Jregz:
you are mixing mysql and pdo functions, it doesn't work that way

how then do I change that to pdo?

sinequanon:


When will folk stop saying "it doesn't work that way"!!

More explanation please.

It seems to me that the connection is successful, because the program gets to the point row=mysql_fetch_row, and it is complaining that the wrong parameter has been passed. This would appear to be because the SELECT has failed and is returning FALSE instead of a result set.

that was the answer to his problem, he connected with pdo and is trying to fetch data with myqsl* functions that he hasn't connected with, the place where he used mysql_connect should have his credentials, the way he checked for mysql_connect would only check if the function is available, nothing more

Jregz got here before me. That's what I would have said.

mixing mysql and pdo functions is bad practice and should never be encouraged.

Thirdwrist:
how then do I change that to pdo?

I have updated your code

<?php
class connect{
    public $db_host= "localhost";
    public $username="";
    public $password= "";
    public $db_name="";
    public $dbc;
  
   function db_connect()
   {
		try{
	    	$this->dbc = new PDO("mysql:host=$this->db_host; dbname=$this->db_name", $this->username, $this->password);
	   	}
	   	catch (PDOException $e){
	    	echo "failed to connect to database pdo ";
	        echo $e->getmessage();
	        exit();
	   	}

		return $this->dbc;
	}

 	public $sql, $row, $result;
	
	public function tester()
	{
		if(mysql_connect()){
			$this->stmt = $dbc->prepare("SELECT email FROM users WHERE id =:id" ;
			$this->stmt->execute(["id" => 1]);

			while($this->row = $stmt->fetch(PDO::FETCH_ASSOC)) {
				echo $this->row['name'];
			}
	}
}

	$connection = new connect();
	$connection->db_connect();
	echo "you are an OOP genius";
	$connection->tester();
	echo $connection->sql;
?>

Note the updated code is not tested.