Grandlord
brukx


Python gurus where are you, help me with this


This code have been giving me sleepless night.



class Loan:
def __init__(self, annualInterestRate = 2.5,
numberOfYears = 1, loanAmount = 1000, borrower = " ":
self.__annualInterestRate = annualInterestRate
self.__numberOfYears = numberOfYears
self.__loanAmount = loanAmount
self.__borrower = borrower

def getAnnualInterestRate(self):
return self.__annualInterestRate

def getNumberOfYears(self):
return self.__numberOfYears

def getLoanAmount(self):
return self.__loanAmount

def getBorrower(self):
return self.__borrower

def setAnnualInterestRate(self, annualInterestRate):
self.__annualInterestRate = annualInterestRate

def setNumberOfYears(self, numberOfYears):
self.__numberOfYears = numberOfYears

def setLoanAmount(self, loanAmount):
self.__loanAmount = loanAmount

def setBorrower(self, borrower):
self.__borrower = borrower

def getMonthlyPayment(self):
monthlyInterestRate = self.__annualInterestRate / 1200
monthlyPayment = \
self.__loanAmount * monthlyInterestRate / (1 - (1 /
(1 + monthlyInterestRate) ** (self.__numberOfYears * 12)))
return monthlyPayment

def getTotalPayment(self):
totalPayment = self.getMonthlyPayment() * \
self.__numberOfYears * 12
return totalPayment

Your indentation is wrong.
Learn how to arrange your python code properly.

olamidedivotee:
Grandlord
brukx


Python gurus where are you, help me with this


This code have been giving me sleepless night.



class Loan:
def __init__(self, annualInterestRate = 2.5,
numberOfYears = 1, loanAmount = 1000, borrower = " ":
self.__annualInterestRate = annualInterestRate
self.__numberOfYears = numberOfYears
self.__loanAmount = loanAmount
self.__borrower = borrower

def getAnnualInterestRate(self):
return self.__annualInterestRate

def getNumberOfYears(self):
return self.__numberOfYears

def getLoanAmount(self):
return self.__loanAmount

def getBorrower(self):
return self.__borrower

def setAnnualInterestRate(self, annualInterestRate):
self.__annualInterestRate = annualInterestRate

def setNumberOfYears(self, numberOfYears):
self.__numberOfYears = numberOfYears

def setLoanAmount(self, loanAmount):
self.__loanAmount = loanAmount

def setBorrower(self, borrower):
self.__borrower = borrower

def getMonthlyPayment(self):
monthlyInterestRate = self.__annualInterestRate / 1200
monthlyPayment = \
self.__loanAmount * monthlyInterestRate / (1 - (1 /
(1 + monthlyInterestRate) ** (self.__numberOfYears * 12)))
return monthlyPayment

def getTotalPayment(self):
totalPayment = self.getMonthlyPayment() * \
self.__numberOfYears * 12
return totalPayment

There's error in indentation

First, your code is too verbose, using class is an overkill for this mortgage calculator.
You can use function but it is fine if you really wanna use class but note that when defining a class, your method indentation must be accurate, like everything must be lined up together, press backspace for everything under the class and use tab key to indent them once.

Taofeekdboy:
First, your code is too verbose, using class is an overkill for this mortgage calculator.
You can use function but it is fine if you really wanna use class but note that when defining a class, your method indentation must be accurate, like everything must be lined up together, press backspace for everything under the class and use tab key to indent them once.

I will try that

Indentation gone wrong

olamidedivotee:

I will try that

Op, try also to learn how to debug as this is a powerful tool in programming, TypeError, ValidationError, ValueError, IndentationError, KeyError should be something you should be familiar with so that you can figure it out yourself and know whats wrong.

Taofeekdboy:

Op, try also to learn how to debug as this is a powerful tool in programming, TypeError, ValidationError, ValueError, IndentationError, KeyError should be something you should be familiar with so that you can figure it out yourself and know whats wrong.

Okay

I'll do it later in the evening.
I've headache now from modularizing codes to this one.

olamidedivotee:
Grandlord
brukx


Python gurus where are you, help me with this


This code have been giving me sleepless night.



class Loan:
def __init__(self, annualInterestRate = 2.5,
numberOfYears = 1, loanAmount = 1000, borrower = " ":
self.__annualInterestRate = annualInterestRate
self.__numberOfYears = numberOfYears
self.__loanAmount = loanAmount
self.__borrower = borrower

def getAnnualInterestRate(self):
return self.__annualInterestRate

def getNumberOfYears(self):
return self.__numberOfYears

def getLoanAmount(self):
return self.__loanAmount

def getBorrower(self):
return self.__borrower

def setAnnualInterestRate(self, annualInterestRate):
self.__annualInterestRate = annualInterestRate

def setNumberOfYears(self, numberOfYears):
self.__numberOfYears = numberOfYears

def setLoanAmount(self, loanAmount):
self.__loanAmount = loanAmount

def setBorrower(self, borrower):
self.__borrower = borrower

def getMonthlyPayment(self):
monthlyInterestRate = self.__annualInterestRate / 1200
monthlyPayment = \
self.__loanAmount * monthlyInterestRate / (1 - (1 /
(1 + monthlyInterestRate) ** (self.__numberOfYears * 12)))
return monthlyPayment

def getTotalPayment(self):
totalPayment = self.getMonthlyPayment() * \
self.__numberOfYears * 12
return totalPayment

Big boy, use the nairaland code tags around your code so we can see where the indentation error occurred. Or better still take a shot of it on your PC.

Taofeekdboy:
First, your code is too verbose, using class is an overkill for this mortgage calculator.
You can use function but it is fine if you really wanna use class but note that when defining a class, your method indentation must be accurate, like everything must be lined up together, press backspace for everything under the class and use tab key to indent them once.

I think maybe he wants to get used to OOP, ASAP, which isn't bad.

Always be consistent with your Indenting in python. If its tab ure using, use it throughout the code. The same goes when ure using 4 spaces...

Also, Whenever u copy and paste a code, always re-indent it to avoid such errors.

1st --Your code is too verbose

2nd-- there is error in indentation

Note: the error might not necessarily be on that specific line, so go through the code from bottom up, and use the '#' to silence any code or block of code that's OK, like I said from bottom upwards.
sometimes the error on a line might be related to the previous line.

Area where i think should improve on is how to use @property decorator to change the behavior of getter methods where necessary, remove setter method where not needed and the class will be perfect. Just my few cents

Grandlord:
Big boy, use the nairaland code tags around your code so we can see where the indentation error occurred. Or better still take a shot of it on your PC.

Show us how

Brukx:

Show us how

[Code]
[/code]

Change C to c

Example 

class hello:
    pass

gbolly1151:


[Code]
[/code]

Change C to c

Example 

class hello:
    pass

Thanks

stanliwise:
Your indentation is wrong.
Learn how to arrange your python code properly.

check your indentation in line 40

Brukx:

Show us how

[code][/code]

olamidedivotee:
Grandlord
brukx


Python gurus where are you, help me with this


This code have been giving me sleepless night.

 class Loan:
 	def __init__(self, annualInterestRate = 2.5,
 			numberOfYears = 1, loanAmount = 1000, borrower = " ":
 			self.__annualInterestRate = annualInterestRate
 			self.__numberOfYears = numberOfYears
 			self.__loanAmount = loanAmount
 			self.__borrower = borrower
			
 def getAnnualInterestRate(self):
 	return self.__annualInterestRate
	
 def getNumberOfYears(self):
 	return self.__numberOfYears
	
 def getLoanAmount(self):
 	return self.__loanAmount
	
 def getBorrower(self):
 	return self.__borrower
	
 def setAnnualInterestRate(self, annualInterestRate):
 	self.__annualInterestRate = annualInterestRate
	
 def setNumberOfYears(self, numberOfYears):
 	self.__numberOfYears = numberOfYears
	
 def setLoanAmount(self, loanAmount):
 	self.__loanAmount = loanAmount
	
 def setBorrower(self, borrower):
 	self.__borrower = borrower
	
 def getMonthlyPayment(self):
 		monthlyInterestRate = self.__annualInterestRate / 1200
 		monthlyPayment = \
 			self.__loanAmount * monthlyInterestRate / (1 - (1 /
 			(1 + monthlyInterestRate) ** (self.__numberOfYears * 12)))
 		return monthlyPayment
		
 	def getTotalPayment(self):
 		 totalPayment = self.getMonthlyPayment() * \
 		 	self.__numberOfYears * 12
 		 return totalPayment

As you can see, only your first and last function are properly indented. That's the issue

Brukx:


As you can see, only your first and last function are properly indented. That's the issue

I've done it